fix: send CSRF-Token with GET requests #54605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new api expects this and there's no harm in sending it. Doing so should make the exam specs pass.
github-actions
bot
added
the
platform: learn
ShaunSHamilton
approved these changes
May 2, 2024
raisedadead
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new api expects this header for more routes than the old api does. While we could make the new api ignore the header for all GET requests, it's easier to make the client provide it. The security benefits are small, but redundancy in security is a good thing.
These changes are included in #54546, so this PR is mostly for visibility.
Checklist:
mainbranch of freeCodeCamp.